Add UTS #46 support #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
==========================================
- Coverage 100% 99.31% -0.69%
==========================================
Files 1 3 +2
Lines 1 147 +146
==========================================
+ Hits 1 146 +145
- Misses 0 1 +1
Continue to review full report at Codecov.
|
|
I've updated this to take a runtime dependency on the |
|
I rebased on current master which seems to have horribly confused codecov. |
onli
added a commit
to portier/sinatra-portier
that referenced
this pull request
Jan 17, 2018
In the future the token will no longer contain ['email']. Normalization is done by the broker now, the simpleidn gem used here however does not always produce the same result. Merging mmriis/simpleidn#13 will fix this.
|
I'm sorry this has taken so long. Thanks for the PR. |
|
0.1.1 pushed to rubygems now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for UTS #46 (http://unicode.org/reports/tr46/). One of the requirements of UTS #46 is to perform Unicode normalization. This was only added natively in Ruby 2.2. It will load the unf gem if no supported method is available.
I'm not sure if this is the best strategy, but it works.
This includes the full UST #46 test suite which all pass.